Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Vectorize JSON payloads #6548

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

garvit-gupta
Copy link
Contributor

@garvit-gupta garvit-gupta commented Aug 21, 2024

What this PR solves / how to test

Add content-type header to Vectorize POST operations
Fix Vectorize getVcetors, deleteVectors payload in Wrangler Client

Fixes #6516/VS-269 and VS-271.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: Tests with mocked responses exist. Only adding a header to Vectorize requests.
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: Only adding a header to Vectorize requests.
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: No change in public facing operations.

@garvit-gupta garvit-gupta requested a review from a team as a code owner August 21, 2024 14:14
Copy link

changeset-bot bot commented Aug 21, 2024

🦋 Changeset detected

Latest commit: e3c5c96

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 21, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507745353/npm-package-wrangler-6548

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6548/npm-package-wrangler-6548

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507745353/npm-package-wrangler-6548 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507745353/npm-package-create-cloudflare-6548 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507745353/npm-package-cloudflare-kv-asset-handler-6548
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507745353/npm-package-miniflare-6548
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507745353/npm-package-cloudflare-pages-shared-6548
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507745353/npm-package-cloudflare-vitest-pool-workers-6548
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507745353/npm-package-cloudflare-workers-editor-shared-6548
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507745353/npm-package-cloudflare-workers-shared-6548

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.72.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240806.1
workerd 1.20240821.1 1.20240821.1
workerd --version 1.20240821.1 2024-08-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@garvit-gupta garvit-gupta changed the title fix(#6516)/VS-269: Add content-type header to Vectorize POST operations fix(#6516)/VS-269: Add Vectorize JSON payloads Aug 21, 2024
@garvit-gupta garvit-gupta changed the title fix(#6516)/VS-269: Add Vectorize JSON payloads fix: Fix Vectorize JSON payloads Aug 21, 2024
.changeset/rare-cooks-marry.md Outdated Show resolved Hide resolved
@penalosa penalosa merged commit 439e63a into cloudflare:main Aug 23, 2024
18 checks passed
@garvit-gupta garvit-gupta deleted the garvit/VS-269/json-header branch August 23, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Error when wrangler vectorize create-metadata-index on Vectorize V2
2 participants